Skip to content

Conversation

@pombredanne
Copy link
Member

This PR prepares release 30.0.0

This helps keep templates simple.
Also move position of models Meta and __str__ to a conventional location
right after the field definitions.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Use search as form field name consistently #907
  This replaces the vulnerability_id and package_name and esnure we have
  a better looking URL with a "search" query string.

* Also make "search" a required field and use standard HTML for
  validation. Remove JS validations.

* Use vulnerability_id rather than PK for URL in templates

* Remove redundant, repeat display of search queries.

* Rename "Total records" to "results" in search results pages

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Use purl slug and URL route for packages
* Use in forms, urls and templates, including a get_absolute_url()
  method.

* Rename VulnerabiltyForm forms to VulnerabiltySearchForm

* Rename PackageForm forms to PackageSearchForm

* Use new pagination template includes in search results templates. The
  pagination is the same repeated at the top and botton of the search
  results

* Display on 20 search results per page.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This limit the flickering to the vulnerability details.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne and others added 6 commits September 9, 2022 16:39
This new improver adds missing CVE reference id that were not created
by their importer.

Note that the current approach for improvers seems to be restricted to
advisories and hsould be relaxed to better handle the general cases.
Here this improver does not deal with advisories at all.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Use the same layout and remove generated comments

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Also validate full_clean in the improve_runner to ensure we do not
have empty, invalid or blank URLs.

Refactor code to add new Manager to VulnerabilityReference and Package
Add convenience method accordingly to create Pckage from purls

Reference: #818
Co-authored-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pombredanne pombredanne merged commit 6688cb6 into main Sep 9, 2022
@pombredanne pombredanne deleted the prepare-release30 branch September 9, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants