Skip to content

Conversation

@johnmhoran
Copy link
Member

Reference: #885
Reference: #886
Reference: #887
Reference: #888

Signed-off-by: John M. Horan johnmhoran@gmail.com

Reference: #885
Reference: #886
Reference: #887
Reference: #888

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Copy link
Member Author

@AyanSinhaMahapatra -- these 4 issues are done and this PR is ready for your review and comments when you have time. Thanks in advance. 👍

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnmhoran, this resolves all the issues #885 #886 #887 #888 and all the other changes make sense too. This looks great.

Nothing major to add here, just one small additional comment unrelated to these issues,
the section title in overview : https://nexb-vulnerablecode--890.com.readthedocs.build/en/890/introduction.html#should-i-use-vulnerablecode probably can be something else instead of should I use vulnerablecode because that answer is always yes! Maybe it can be Is vulnerablecode stable? or something to that extent. But this is probably minor and I could also be wrong here.

We can also make the Recent presentations: part a new section at the end of this page as we this list will continue to grow and this is a major point also (thanks to @TG1999 @Hritik14 @pombredanne and everyone else!)

I checked the docs at https://nexb-vulnerablecode--890.com.readthedocs.build/en/890/, everything looks great there too, and I'll add issues if I see anything else here.

You need to merge the main branch into this one or rebase for this to be merged though.

But this can be merged and the issues closed! Thanks

Signed-off-by: John M. Horan johnmhoran@gmail.com
Reference: #890

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Copy link
Member Author

Ready to be merged . . . merging.

@johnmhoran johnmhoran merged commit 9f89bca into main Sep 2, 2022
@pombredanne pombredanne deleted the update-rtd branch September 7, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants