npm importer - improver migration #805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ziad <ziadhany2016@gmail.com>
Signed-off-by: ziad <ziadhany2016@gmail.com>
Signed-off-by: ziad <ziadhany2016@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: ziad <ziadhany2016@gmail.com>
Signed-off-by: ziad <ziadhany2016@gmail.com>
Signed-off-by: ziad <ziadhany2016@gmail.com>
# Conflicts: # vulnerabilities/importer.py # vulnerabilities/importers/__init__.py
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
TG1999
requested changes
Sep 22, 2022
Contributor
TG1999
left a comment
TG1999
left a comment
There was a problem hiding this comment.
Thanks! please see my feedback for your consideration
| glob = "vuln/npm/**/*.json" # subdir="vuln/npm" | ||
| files = (p for p in path.glob(glob) if p.is_file()) | ||
| for file in files: | ||
| print(file) |
| publish_date = parse(record["updated_at"]) | ||
| publish_date = publish_date.replace(tzinfo=pytz.UTC) | ||
|
|
||
| pkg_manager_api = NpmVersionAPI() |
Contributor
There was a problem hiding this comment.
VersionAPI is needed to be handled at improver side, check github and gitlab importer for same
| aff_ver.add(ver) | ||
|
|
||
| return aff_ver, fix_ver | ||
| def get_fixed_version( |
| Example: | ||
| >>> z = normalize_ranges(">=6.1.3 < 7.0.0 || >=7.0.3") | ||
| >>> assert z == [">=6.1.3,<7.0.0", ">=7.0.3"] | ||
| def map_all_versions(all_versions) -> List[SemverVersion]: |
Contributor
|
Been worked in #960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ziad ziadhany2016@gmail.com