Skip to content

Conversation

@markrouz
Copy link

@markrouz markrouz commented May 6, 2022

No description provided.

@TG1999
Copy link
Contributor

TG1999 commented May 6, 2022

Hey @markrouz , thanks for this, can you add some tests and also sign off the commit, DCO is failing

@markrouz markrouz force-pushed the main branch 4 times, most recently from 56537b5 to 86faba3 Compare May 6, 2022 17:59
@markrouz
Copy link
Author

markrouz commented May 6, 2022

Hey @markrouz , thanks for this, can you add some tests and also sign off the commit, DCO is failing

@TG1999 thanks for pointing this out. Done

Signed-off-by: mark <mark@threatrix.io>
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @pombredanne please have a look here once

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks you ++

@TG1999 TG1999 merged commit 75b2920 into aboutcode-org:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants