Remove null from string based fields #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TG1999
changed the title
pombredanne
requested changes
Apr 15, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM, but are we missing a migration may be?
pombredanne
approved these changes
Apr 15, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM: please just add the missing migration and merge.
TG1999
force-pushed
the
remove_null_from_string_fields
branch
4 times, most recently
from
af46769 to
08c1e7e
Compare
Remove null from string based fields Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
remove_null_from_string_fields
branch
from
08c1e7e to
c01b54b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove null from string based fields
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com