Add example importer and improver #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TG1999
reviewed
Apr 7, 2022
Contributor
|
@Hritik14 Should we have some tests here for testing the example importer and improver ? |
pombredanne
requested changes
Apr 8, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
IMHO this should not be registered as this creates junk data.
Collaborator
Author
|
@TG1999 Good idea! Though, instead of testing this example importer / improver, I suppose I can test the entire framework using the example. @pombredanne |
pombredanne
reviewed
Apr 9, 2022
This is a dummy importer and improver that runs without network connection only to test vulnerablecode framework Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
This creates junk data. This importer should be run inside a test only Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Following are tests associated with example importer and improver to make sure the importer improver framework is working properly. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
It serves as a test data source and does not contribute any actual data. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dummy importer and improver that runs without network
connection only to test vulnerablecode framework
Signed-off-by: Hritik Vijay hritikxx8@gmail.com