Skip to content

Migrate openssl importer to importer-improver model #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 51 commits into from
Closed

Migrate openssl importer to importer-improver model #648

wants to merge 51 commits into from

Conversation

keshav-space
Copy link
Member

@keshav-space keshav-space commented Mar 18, 2022 •
edited
Loading

closes #615
Signed-off-by: Keshav Priyadarshi git@keshav.space

TG1999
TG1999 reviewed Mar 21, 2022
View reviewed changes
TG1999
TG1999 requested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, please check my comments

keshav-space
keshav-space commented Mar 21, 2022
View reviewed changes
pombredanne
pombredanne reviewed Mar 21, 2022
View reviewed changes
TG1999
TG1999 reviewed Mar 22, 2022
View reviewed changes
@keshav-space keshav-space requested a review from TG1999 March 22, 2022 17:27
pombredanne
pombredanne requested changes Mar 24, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See some feedback below for your kind consideration.

@keshav-space keshav-space mentioned this pull request Mar 27, 2022
Merged
Hritik14
Hritik14 requested changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@Hritik14 Hritik14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshav-space Thank you for the updates!! Please consider the following suggestions. Further, we're gonna need as many tests as possible.

@keshav-space keshav-space requested a review from Hritik14 April 4, 2022 19:36
pombredanne
pombredanne requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the updates...we are almost there! just a few nit pickings left.

pombredanne
pombredanne requested changes Apr 8, 2022
View reviewed changes
pombredanne
pombredanne requested changes Apr 8, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to squash and amend your commits to have a cleaner stream of commit messages?

pombredanne
pombredanne requested changes Apr 9, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost there... See a few last nitpickings for your consideration before we merge

@pombredanne
Copy link
Member

I merged some other code... so you have some merge conflicts to resolve now

keshav-space and others added 12 commits April 10, 2022 00:21
@keshav-space
Migrate openssl importer to importer-improver model
393cd16 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@TG1999 @keshav-space
Reference: #604
74422d3 
Migrate github importer to importer-improver model

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 @keshav-space
Reference: https://github.com/vulnerablecode/issue/650
475e7d6 
Work around PostgreSQL index issue

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 @keshav-space
Fix API crash due to model changes
0751bd9 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 @keshav-space
Fix github improver
c9e473d 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@pombredanne @keshav-space
Streamline stripping V prefixes in versions
9045903 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@TG1999 @keshav-space
Add tests for checking API
37aa9e1 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@Hritik14 @keshav-space
Fix improver framework not accepting severities
e970bc0 
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
@Hritik14 @keshav-space
Be explicit about improver vs improver_class
4b7208c 
Same about importer

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
@TG1999 @keshav-space
Migrate nvd importer to importer-improver model
9d80c83 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 @keshav-space
Add spdx license expression
9ebdd7c 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 @keshav-space
Add unit tests and make model changes for storing cpe as reference_id
5c7f63f 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne and others added 27 commits April 10, 2022 00:27
@pombredanne @keshav-space
Do not restart: on-failure
a820740 
This can cause endless, infinite loop of failure/restart

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Aligne Makefile with SCIO
fcae8bb 
Ensure that we always install "dot" locally
Streamline other target
Remove unused targets


Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Bump to use Python 3.9 in Docker image
0b2715b 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Use vulnerablecode not scancode for images
b92ba68 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Use vulnerablecode as a container name, not web
69989f0 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Improve documentation
5da4bc6 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Use proper name
3ee4f99 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Imrpoev env var. handling in settings.py
62a99bf 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Update changelog
8678938 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Improve envt. handling
6d6f966 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Improve code format, duplication and documentation
7eb0b1a 
* Format long lines in doctests.
* Remove dead imports.
* Convert comments to docstring

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Remove empty line
d5ae047 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Migrate pytest settings to pyproject.toml
e7a469a 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Format code
13b97e2 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Re-organize Python and docker setup
20b5e3d 
* Use setup.cfg rather than setup.py
* Use new [dev] extra for development utilities
* Use requirements.txt as constraints for pinning deps. Drop using
  requirements-dev.txt
* Update pyproject.toml for tools including pytest, black and isort
* Update Makefile and Dockerfile accordingly
* Bump version to signal this is a beta
* Update dockerignore and other confif files
* Bump dependencies

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Use non-deprecated logger call
1ac9256 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Correct settinsg for auth
16cb138 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Enable SessionAuthentication
cd15f54 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Make Retes API look better
d6054f1 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Remove ability to edit/create/delete from the UI
b6589f4 
This is too complex and requires more design to enable.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Remove trailing spaces
3248648 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Fix typo
2d728a1 
Reported-by: Hritik Vijay <hritikxx8@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Disable codestyle checks until we have cleaned up the code
c2893b0 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Format code
37d9616 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Improve the CHANGELOG
0998528 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne @keshav-space
Document how we load environment variables from .env
dc4b650 
There is a precedence of /etc/vulnerablecode/.env over the local .env
file in all cases

Reported-by: Hritik Vijay <hritikxx8@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@keshav-space
Merge branch 'main' into main
006d899
@keshav-space keshav-space mentioned this pull request Apr 9, 2022
Merged
@pombredanne
Copy link
Member

Sounds like you are leaning git ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne requested changes

@TG1999 TG1999 Awaiting requested review from TG1999

@Hritik14 Hritik14 Awaiting requested review from Hritik14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openssl importer - improver migration
4 participants
@keshav-space @pombredanne @Hritik14 @TG1999