Skip to content

Fix nix Github workflow #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Conversation

rolfschr
Copy link
Contributor

@rolfschr rolfschr commented Apr 19, 2021

This PR automatically fetches the latest pypi-deps-db before running the automated Nix tests (Github Action). This does not commit the changes. However, this should make the nix tests keep running (on Github) when the requirements.txt change and the obvious fix is to fetch a new version of pypi-deps-db.

Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
@sbs2001
Copy link
Collaborator

sbs2001 commented Apr 19, 2021

Hi @rolfschr thanks :) .

So I guess this won't need any intervention from your side when deps change.

@rolfschr
Copy link
Contributor Author

So I guess this won't need any intervention from your side when deps change.

Well, yes, this was my intention :) I expect that some help may needed if case things break for other reasons than a simple missing (bleeding edge version of a) dependency.

@sbs2001 sbs2001 merged commit 9ff0192 into aboutcode-org:main Apr 19, 2021
@sbs2001
Copy link
Collaborator

sbs2001 commented Apr 19, 2021

Btw @rolfschr we have a PR that removes the pygit dep which AFAIK caused some pain on your side.

They are doing some changes to nix tests, could you review that PR ? #409

@rolfschr rolfschr deleted the fix-nix-workflow branch August 29, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants