-
-
Notifications
You must be signed in to change notification settings - Fork 264
Sanity Checks for redhat import response #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae4f9dd to
67f420c
Compare
|
@sbs2001 PR up for review! |
sbs2001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@savish28 this looks good, see the nits I've left inline
vulnerabilities/importers/redhat.py
Outdated
| value=bugzilla_severity_val, | ||
| ) | ||
| if ( | ||
| ("bugs" in bugzilla_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be made more concise by using bugzilla_data.get("bugs")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbs2001 Done.
vulnerabilities/importers/redhat.py
Outdated
| if ( | ||
| ("bugs" in bugzilla_data) | ||
| and len(bugzilla_data["bugs"]) | ||
| and ("severity" in bugzilla_data["bugs"][0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be made more concise by using bugzilla_data.get["bugs"][0].get("severity")
Signed-off-by: savish <savishbedi1@gmail.com>
sbs2001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Issue Fix: #384.
Added Sanity checks for RedHat import failing.