Skip to content

Correct API docs path and fix pytest invocation #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbs2001 merged 4 commits into from
Mar 18, 2021
Merged

Correct API docs path and fix pytest invocation #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ba22ab
Correct API docs path and fix pytest invocation
Hritik14 Mar 15, 2021
2dadee6
Use venv pytest in CI
Hritik14 Mar 17, 2021
0ee064e
Point docs to http://127.0.0.1:8000/api/docs
Hritik14 Mar 17, 2021
e831c5f
Merge branch 'main' into main
sbs2001 Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ jobs:
pip install -r requirements.txt

- name: Run tests
run: pytest
run: python -m pytest
env:
# The hostname, username used to communicate with the PostgreSQL service container
POSTGRES_HOST: localhost
VC_DB_USER: postgres
POSTGRES_PORT: 5432
DJANGO_DEV: 1
GH_TOKEN: 1
GH_TOKEN: 1
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ before_script:

script:
- ./manage.py collectstatic
- pytest
- python -m pytest

notifications:
email: false
Expand All @@ -27,4 +27,4 @@ notifications:
- https://webhooks.gitter.im/e/b119fa557626081e1f36
on_success: change # options: [always|never|change] default: always
on_failure: always # options: [always|never|change] default: always
on_start: never # options: [always|never|change] default: always
on_start: never # options: [always|never|change] default: always
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ Run Tests
Use these commands to run code style checks and the test suite::

black -l 100 --check .
DJANGO_DEV=1 pytest
DJANGO_DEV=1 python -m pytest
Copy link
Member

@pombredanne pombredanne Mar 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are in an activated virtualenv, pytest should work. Did you experience an issue here?

Copy link
Collaborator Author

@Hritik14 Hritik14 Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. As mentioned here, it fails on the first run. I've generated an asciinema to reproduce the issue as well.



Data import
Expand Down
2 changes: 1 addition & 1 deletion vulnerablecode/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def __init__(self, *args, **kwargs):
urlpatterns = [
path("admin/", admin.site.urls),
path("api/schema/", SpectacularAPIView.as_view(), name="schema"),
path("api/schema/swagger-ui/", SpectacularSwaggerView.as_view(), name="swagger-ui"),
path("api/docs", SpectacularSwaggerView.as_view(), name="swagger-ui"),
path("packages/search", PackageSearchView.as_view(), name="package_search"),
path("packages/<int:pk>", PackageUpdate.as_view(), name="package_view"),
path("vulnerabilities/<int:pk>", VulnerabilityDetails.as_view(), name="vulnerability_view"),
Expand Down