[Refactor] Rename vuln_references to references
#377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@imnitishng thanks for the PR, could you rebase this wtih latest |
Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
sbs2001
requested changes
Mar 15, 2021
Collaborator
sbs2001
left a comment
sbs2001
left a comment
There was a problem hiding this comment.
Code changes LGTM. Could you please update the Advisory definition in the docs at https://github.com/nexB/vulnerablecode/blob/main/docs/how-to-guides/add_new_importer.rst . Sorry for not mentioning this earlier.
Collaborator
|
@imnitishng Never mind you changed the docs already :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #376