Improve Ubuntu OVAL importer #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note that I will need to add tests before we can merge and also the Ubuntu importer still does NOT complete after running for a day. |
Collaborator
|
@pombredanne Any luck with completing the whole import ? |
Member
Author
@sbs2001 I stopped it after several hours and about ~8000 completed (e.g. after the first archive) |
Collaborator
|
I'm running the import at https://github.com/sbs2001/vulnerablecode/runs/1792912071?check_suite_focus=true |
Collaborator
|
@pombredanne I think we should ditch pycodestyle and use black for both checking + formatting like aboutcode-org/skeleton#13 (comment) |
sbs2001
force-pushed
the
improve-ubuntu
branch
from
a39abb9 to
76b39d5
Compare
Correct ABOUT file Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We are not using etag correctly. Also the function name is misleading as we are checking the Etag in this create_etag function Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This importer no longer worked with failures to process some version ranges as RangeSpecifier(). These change imprivae error handling and crude logging using print statements for now. Also apply minor code formatting. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is an "external" library that contains non-passing doctest-like docs. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This makes it easy to reproduce errors by copy/pasting the faulty command. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is triggered when using black-like style Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
…allback mapping Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues with the Ubuntu Oval importer that was stuck.
This resolves some of these issues:
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com