Import apache tomcat #292
Merged
Import apache tomcat #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbs2001
force-pushed
the
import_apache_tomcat
branch
from
6aebce9 to
0b7f2d8
Compare
pombredanne
approved these changes
Dec 11, 2020
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks. See my tiny nits inline for your consideration
| import re | ||
|
|
||
|
|
||
| import requests |
Member
There was a problem hiding this comment.
Please sort your imports ;) ...the best way is to use the isort package for that
| pageh3s = page_soup.find_all("h3") | ||
| vuln_headings = [i for i in pageh3s if "Fixed in Apache Tomcat" in i.text] | ||
| for data in vuln_headings: | ||
| fixed_version = data.text.split("Fixed in Apache Tomcat")[-1].strip() |
Member
There was a problem hiding this comment.
This may be more robust:
_left, _sep, fixed_version = data.text.lower().partition("fixed in apache tomcat")
fixed_version = fixed_version.strip()
0b7f2d8 to
af5e6e7
Compare
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
sbs2001
force-pushed
the
import_apache_tomcat
branch
from
af5e6e7 to
2795792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #106
Based on top of #278