Skip to content

Conversation

@tushar912
Copy link
Contributor

Fixes #282 .

Description

I have added FAQ section in doc with a question related to importing data while setting up.

Screenshot

rst

@sbs2001
Copy link
Collaborator

sbs2001 commented Nov 22, 2020

@tushar912 thanks for the PR

Could you instead of adding a separate file for FAQ, mention it somewhere in the README.rst ?

Also for now don't create a separate FAQ section at the README. Instead mention running few importers in the setup section itself .

Do fix the DCO check too :) They have nice instructions at https://github.com/nexB/vulnerablecode/pull/283/checks?check_run_id=1435132472 .

@tushar912
Copy link
Contributor Author

@sbs2001 I have made the changes . I tried to fix DCO but I am unable to fix it even after multiple times .

@tushar912
Copy link
Contributor Author

I think git commit --amend --signoff sign off only latest commit

Signed-off-by: Tushar912 <tushar.912u@gmail.com>
@tushar912
Copy link
Contributor Author

@sbs2001 I did rebase so it is passing the test now.

Copy link
Collaborator

@sbs2001 sbs2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit :

How about rephrasing In fact it is suggested to run only a few small importers via to To quickly get started with some data run : ?

Signed-off-by: Tushar912 <tushar.912u@gmail.com>
@tushar912
Copy link
Contributor Author

I have made the changes

@tushar912 tushar912 requested a review from sbs2001 November 23, 2020 09:44
@sbs2001 sbs2001 merged commit 7f8ae63 into aboutcode-org:main Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add FAQ section in docs

2 participants