Refactor GitlabDataSource to work with browser extension #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelehab
force-pushed
the
vulntotal-change-gitlab-datasource
branch
2 times, most recently
from
a3583f4 to
569e2f2
Compare
keshav-space
requested changes
Jul 29, 2024
Member
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
Thanks @michaelehab!
See some nits below and add DCO to your commits.
Collaborator
Author
There was a problem hiding this comment.
In the test code, I read the contents of temp_vulntotal_gitlab_datasource folder, and this file is not included in the parsed_advisory-expected so the test was failing when we had it
michaelehab
force-pushed
the
vulntotal-change-gitlab-datasource
branch
from
3761d09 to
f5a1163
Compare
keshav-space
requested changes
Aug 5, 2024
Member
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
@michaelehab You need to properly rebase or merge with the main branch without modifying the original commits. Let me know if you need help with this.
-Update Gitlab Datasource tests -Reorder test_parse_interesting_advisories test files -Format changed files with black -Merge fetch yml logic and update method doc Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
michaelehab
force-pushed
the
vulntotal-change-gitlab-datasource
branch
from
e2298be to
8bc0445
Compare
Collaborator
Author
|
@keshav-space I squashed the changes and properly merged them with the main branch. Thank you! |
Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
keshav-space
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1523
This PR streamlines the GitLab datasource by eliminating the need for retrieving the repo subtree as a tar.gz file. Instead, it directly fetches YAML files from the repository. This change enhances compatibility, especially in Chrome extensions, and simplifies the codebase.
Changes Made:
Testing: