Skip to content

Conversation

@ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented Jul 9, 2024

Screenshot from 2024-07-19 01-19-53

Screenshot from 2024-07-19 01-29-31

issue #1487

@TG1999
Copy link
Contributor

TG1999 commented Jul 16, 2024

@ziadhany please add tests and some screenshots of UI thanks!

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
Copy link
Collaborator Author

ziadhany commented Jul 18, 2024

@ziadhany please add tests and some screenshots of UI thanks!

@TG1999 Done! I added a small test for the API and updated the screenshots. Currently, we don't have any importer or improver to show the reference type, but I manually updated one of the references to see the result on the UI.

@TG1999 TG1999 merged commit 474301d into aboutcode-org:main Jul 22, 2024
@ziadhany ziadhany deleted the ref-type branch July 22, 2024 15:29
TG1999 added a commit that referenced this pull request Jul 22, 2024
TG1999 added a commit that referenced this pull request Jul 22, 2024
@TG1999 TG1999 mentioned this pull request Jul 22, 2024
@ziadhany
Copy link
Collaborator Author

@TG1999, I'm unable to reopen this pull request. Should I create a new one instead?

TG1999 added a commit that referenced this pull request Jul 22, 2024
ziadhany pushed a commit that referenced this pull request Aug 1, 2024
This reverts commit 6727786.

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
TG1999 added a commit that referenced this pull request Aug 6, 2024
* Revert "Revert "Add support for reference_type (#1502)" (#1517)"

This reverts commit 6727786.

Signed-off-by: ziadhany <ziadhany2016@gmail.com>

* Fix cargo test

Signed-off-by: ziadhany <ziadhany2016@gmail.com>

* Fix test by adding reference_type to ordering list

Signed-off-by: ziadhany <ziadhany2016@gmail.com>

* Regen apache_kafka test fixture

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

---------

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Co-authored-by: ziadhany <ziadhany2016@gmail.com>
Co-authored-by: Keshav Priyadarshi <git@keshav.space>
ziadhany pushed a commit to ziadhany/vulnerablecode that referenced this pull request Aug 6, 2024
…boutcode-org#1517)"

This reverts commit 6727786.

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
ziadhany pushed a commit to ziadhany/vulnerablecode that referenced this pull request Sep 2, 2024
…boutcode-org#1517)"

This reverts commit 6727786.

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants