Fix Encoding Type in Fireeye Importer #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
TG1999
requested changes
Jan 25, 2024
Contributor
TG1999
left a comment
TG1999
left a comment
There was a problem hiding this comment.
Please add tests for verifying the code change :)
This test checks for UTF-8-SIG encoding Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
TG1999
added a commit
to TG1999/vulnerablecode
that referenced
this pull request
Jul 19, 2024
* Fix Encoding Type in Fireeye Importer Signed-off-by: Harsh Mishra <hmisraji07@gmail.com> * Add Test to Fireeye Importer This test checks for UTF-8-SIG encoding Signed-off-by: Harsh Mishra <hmisraji07@gmail.com> * Reformat test_fireeye.py Signed-off-by: Harsh Mishra <hmisraji07@gmail.com> --------- Signed-off-by: Harsh Mishra <hmisraji07@gmail.com> Co-authored-by: Tushar Goel <34160672+TG1999@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1403