Mark advisories status according to NVD advisory #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TG1999
force-pushed
the
rejected_cves
branch
from
8266076 to
00639d3
Compare
TG1999
changed the title
pombredanne
reviewed
Nov 13, 2023
vulnerabilities/models.py
Outdated
| class VulnerabilityStatusType(models.IntegerChoices): | ||
| """List of vulnerability statuses.""" | ||
|
|
||
| PUBLISHED = 1, "published" |
Member
There was a problem hiding this comment.
The code in https://github.com/nexB/vulnerablecode/pull/1232/files#diff-3e8fc96d993d0bd8585642f68239732a30a19b7ec100a36ee5d21e209625ff81R120 seem redundant. Could we have a single label, either as "published" or "Published" but not both?
pombredanne
reviewed
Nov 13, 2023
vulnerabilities/views.py
Outdated
| def get_queryset(self): | ||
| return super().get_queryset().prefetch_related("references", "aliases", "weaknesses") | ||
|
|
||
| def get_status(self, status): |
Member
There was a problem hiding this comment.
This method should be moved to VulnerabilityStatusType IMHO
pombredanne
approved these changes
Nov 13, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
I added some nits... please merge when you feel comfy!
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
rejected_cves
branch
from
91dd689 to
9d29cbd
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1281