Skip to content

Conversation

@swastkk
Copy link

@swastkk swastkk commented Apr 11, 2023

Added the Dark Mode toggle in the documentation.
Reference - https://github.com/MrDogeBro/sphinx_rtd_dark_mode

With light mode-
Screenshot_2023-04-11_18-32-40

With Dark Mode-
Screenshot_2023-04-11_18-32-58

swastkk added 2 commits April 11, 2023 18:33
Signed-off-by: swastik <swastkk@gmail.com>
Signed-off-by: swastik <swastkk@gmail.com>
@TG1999 TG1999 added this to the v33.0.0 milestone Apr 11, 2023
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swastkk
Copy link
Author

swastkk commented Apr 11, 2023

Should add it in the v32.0.0rc4 or create a new with v33.0.0 ?

@TG1999
Copy link
Contributor

TG1999 commented Apr 11, 2023

@swastkk add a new heading Next Release and add it under that

swastkk and others added 3 commits April 11, 2023 22:30
Signed-off-by: swastik <swastkk@gmail.com>
@TG1999
Copy link
Contributor

TG1999 commented Apr 11, 2023

@swastkk please squash your commits and please use assertive commit messages instead of Dark Mode for the documentation added it should be Add dark mode for the documentation

swastkk added 2 commits April 11, 2023 22:55
Signed-off-by: swastik <swastkk@gmail.com>

* Added these changes in next Release in CHANGELOG.rst
@swastkk swastkk closed this Apr 11, 2023
@swastkk swastkk deleted the dark-mode-documentation branch April 11, 2023 17:35
@swastkk
Copy link
Author

swastkk commented Apr 11, 2023

Don't know what is happening today :"( , not my day
Creating fresh PR with 1 commit having everything.

@swastkk
Copy link
Author

swastkk commented Apr 11, 2023

Don't know what is happening today :"( , not my day Creating fresh PR with 1 commit having everything.

Got the reason why all these chaos was going on forgot to use -f in the git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants