Skip to content

Add tests for improver #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hritik14 merged 2 commits into from
Aug 31, 2023
Merged

Add tests for improver #1081

Hritik14 merged 2 commits into from
Aug 31, 2023

Conversation

@Hritik14
Copy link
Collaborator

@Hritik14 Hritik14 commented Jan 14, 2023 •
edited
Loading

fixes: #612
Signed-off-by: Hritik Vijay hritikxx8@gmail.com

@Hritik14 Hritik14 mentioned this pull request Jan 17, 2023
Open
@Hritik14 Hritik14 marked this pull request as ready for review January 17, 2023 15:59
@Hritik14 Hritik14 requested a review from pombredanne January 17, 2023 15:59
@Hritik14 Hritik14 changed the title [WIP] Add tests for improver Add tests for improver Jan 17, 2023
@TG1999 TG1999 added this to the v32.0.0 milestone Jan 17, 2023
@Hritik14 Hritik14 force-pushed the tests branch 2 times, most recently from 2b5d1ee to 7f27fc5 Compare January 29, 2023 19:10
@TG1999
Copy link
Contributor

TG1999 commented Apr 12, 2023 •
edited
Loading

@Hritik14 tests are failing on CI , please re-run your tests once on the CI for 3.10

@Hritik14 Hritik14 force-pushed the tests branch 2 times, most recently from 2bf5a16 to 5f1b029 Compare May 10, 2023 20:23
@Hritik14
Copy link
Collaborator Author

Hritik14 commented May 10, 2023

@TG1999 This does not make sense.
Failed: https://github.com/nexB/vulnerablecode/actions/runs/4941002519/attempts/1
Passed: https://github.com/nexB/vulnerablecode/actions/runs/4941002519/attempts/2

Only re-running the jobs made the tests pass without any code change.

@TG1999
Copy link
Contributor

TG1999 commented May 11, 2023

@Hritik14 it seems to me it's a Heisenbug ?

@Hritik14
Copy link
Collaborator Author

Hritik14 commented May 12, 2023

@TG1999 Possibly

@TG1999 TG1999 modified the milestones: v32.0.0, v33.0.0 May 17, 2023
@TG1999 TG1999 force-pushed the tests branch 2 times, most recently from c1143af to cccc233 Compare August 28, 2023 09:48
@Hritik14 @TG1999
Add tests for improver
c58cf36 
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
@Hritik14 @TG1999
Add tests for improve_runner
facf2a7 
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
TG1999
TG1999 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks++

@Hritik14 Hritik14 merged commit f8412dc into aboutcode-org:main Aug 31, 2023
@Hritik14 Hritik14 deleted the tests branch August 31, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TG1999 TG1999 TG1999 approved these changes

@pombredanne pombredanne Awaiting requested review from pombredanne

Assignees

@TG1999 TG1999

Labels

None yet

Projects

None yet

Milestone

v33.0.0

Development

Successfully merging this pull request may close these issues.

Write tests for improvers base class

2 participants

@Hritik14 @TG1999