Replace packaging with packvers in src/scripts #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pombredanne review please :") |
swastkk
changed the title
pombredanne
requested changes
Jan 10, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thank you!
Please add also packvers to https://github.com/nexB/skeleton/blob/main/etc/scripts/requirements.txt
Contributor
Author
Done ✔️ |
pombredanne
changed the title
pombredanne
requested changes
Jan 12, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Actually, one last change if you do not mind:
Can you squash and update your commit message?
Thanks!
* import update in src/scripts/utils_dejacode * Packvers replacing packaging in other src/scripts * Added packvers in src/scripts/requirments.txt Signed-off-by: swastik <swastkk@gmail.com>
swastkk
force-pushed
the
packvers-added
branch
from
e75ddd3 to
1bd7a2f
Compare
Contributor
Author
okay now? |
pombredanne
approved these changes
Jan 12, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks!
we want to have one empty line after the subject line for next time. I am merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70
and aboutcode-org/python-inspector#109 (comment)
Signed-off-by: swastik swastkk@gmail.com