Include metadata in release archive, update package names, reduce package size #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
OmkarPh
changed the title
OmkarPh
changed the title
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
…handling native modules Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
This was
linked to
issues
Dec 25, 2023
Review dependencies and ensure we have the bare minimum dependencies declared & used at runtime
#621
Closed
OmkarPh
changed the title
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
OmkarPh
force-pushed
the
fix/packaging-structure
branch
from
6d8860b to
8b0703b
Compare
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
OmkarPh
force-pushed
the
fix/packaging-structure
branch
from
c05730a to
d61fc87
Compare
AyanSinhaMahapatra
approved these changes
Jan 15, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@OmkarPh LGTM!
Thanks ++
See a couple minor comments below, and also update the relevant meta-issues
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531 #621 #622
You can see archives in this test CI release - https://github.com/OmkarPh/scancode-workbench/releases/tag/v4.0.1-src-packages
New archives are only ~20 MBs smaller, but the unpackaged application size has reduced from >400 MBs to ~300 MBs