-
-
Notifications
You must be signed in to change notification settings - Fork 80
UI improvements in Dependencies dashboard & Packages explorer #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
…riment/dependenciesViews
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
…riment/dependenciesViews
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmkarPh thanks++ updates look good!
A couple of nits for your consideration.
- In the left main views section and the
viewin the bar above we havePackages Explorer, but once you're there the header isPackages and Dependencies explorer. We have to be consistent here and use only one. I'm leaning towardsPackages Explorerhere, but your call. - In the
Packages Explorerwhen you click on one of the dependencies on the left, you have the details with the dependency attributes and their values. The you have their respective raw JSON there but it's titledRaw package, it should beRaw dependencyinstead? - In the dependency info dashboard, in the table of values by package type, we have a
No Value detectedthere. I'm not sure we have PURLs without package types here, do you have an example of this? In any case let me check SCTK if there are actual instances of these. If not we can remove this row, and irrespective of that, we should only show this if there are values with no package type. - In the dependency info dashboard, in the table of values by package type, maybe we should have a title for the table like we have for other charts?
- In the new dependencies table (and now that I notice it in the license matches table too similarly) we have empty space on the right in case of larger screens or even if you do full screen in smaller screens, while we still have some fields which are collapsed to a the second line. Do you think we can set these column values set such as we have minimum values for these, which will be there and then henceforth if it has more space than sum of the minimum of the column widths, we expand only some columns by proportions (while keeping smaller ones fixed). This is an enhancement and minor, if possible.
|
A minor point but names like Packages Explorer should be singular in most cases - e.g., Package Explorer |
Yep, having only
My bad, it has to be |
I don't have a good title on top of my head, but what would be a good word to collectively represent |
|
The name that we usually use for Runtime, Optional etc. Dependency Scope. |
I can think of some options:
|
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Sure, here's a scan that had this value, attaching a screenshot too. I checked other JSONs and this does not seem to be present in all of them. Also just a nit, notice how the table has only a few rows but takes up a lot more space than necessary, we should probably reduce the table height when there's not enough rows? |
…ge_data Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
|
Hi @AyanSinhaMahapatra For the table width & height, there are some other changes in other branches which need to be taken into account, hence it is tracked separately in #598 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| purl: null, | ||
| }; | ||
|
|
||
| // Obtaining a misc package via function to prevent preserving the same object across rerenders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
Thanks @AyanSinhaMahapatra |


Updated charts:

Dependencies summary table:

Tabulated dependencies in the package view itself (Dependencies explorer on the left still works as before)

The packages view on the right didn't require much horizontal space, hence it was set to a default ~50% before
But, with the added table, it's changed to a default 65% (Suggest any other ratios, which suit better in most cases)
(It is resizable as usual)