Fix false-positive detection of generic 'open source license' phrase #4715
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved free-unknown_88.RULE to inactive directory as it was causing false positives when scanning casual documentation that mentions 'open source license'. This resolves issue aboutcode-org#4221 where ts-jest README was incorrectly flagged with LicenseRef-scancode-free-unknown. The rule matched only 3 words ('open source license') with low relevance (50), making it too broad and triggering on non-licensing contexts. Added test case to prevent regression: - tests/licensedcode/data/datadriven/unknown/ts-jest-no-false-positive.md - tests/licensedcode/data/datadriven/unknown/ts-jest-no-false-positive.md.yml Fixes: aboutcode-org#4221 Signed-off-by: Aliasghar Jawadwala <sharksurfauto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved free-unknown_88.RULE to inactive directory as it was causing false positives when scanning casual documentation that mentions 'open source license'. This resolves issue #4221 where ts-jest README was incorrectly flagged with LicenseRef-scancode-free-unknown.
The rule matched only 3 words ('open source license') with low relevance (50), making it too broad and triggering on non-licensing contexts.
Added test case to prevent regression:
Fixes: #4221
Fixes #0000
Tasks
Run tests locally to check for errors.