Skip to content

Add new BSD license rule #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add new BSD license rule #4040

wants to merge 2 commits into from

Conversation

NucleonGodX
Copy link
Contributor

@NucleonGodX NucleonGodX commented Dec 26, 2024 •
edited
Loading

Fixes #4018

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: NucleonGodX manitsingh018@gmail.com

@NucleonGodX NucleonGodX changed the title Added new-bsd variant as a rule Added new BSD variant as a rule Dec 26, 2024
pombredanne
pombredanne requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looking good!
Do you mind to amend the commit message?
We like to use imperative style.
Rather than "new bsd variant added as a rule", what about:

"Add BSD license detection rule #4018"

We have some doc on how to write good commit messages: See https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

@pombredanne
Copy link
Member

Please also rename your PR using the imperative style, and apply the same approach to your other PRs.

@NucleonGodX
Add BSD license detection rule aboutcode-org#4018
49b530f 
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
@NucleonGodX NucleonGodX changed the title Added new BSD variant as a rule Add new BSD license rule Dec 31, 2024
@NucleonGodX
Copy link
Contributor Author

NucleonGodX commented Dec 31, 2024 •
edited
Loading

Thanks for the suggestions @pombredanne , I've implemented them here and in other PRs.

@pombredanne
Copy link
Member

Also the rule needs to be renamed to something that is unique to avoid conflicts.

@NucleonGodX
change file name
3278ae4 
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
@NucleonGodX
Copy link
Contributor Author

Also the rule needs to be renamed to something that is unique to avoid conflicts.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new BSD minor variant as a rule
2 participants
@NucleonGodX @pombredanne