Support conan in packagedcode #3650
Conversation
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
keshav-space
force-pushed
the
2388-support-conan
branch
from
6b1a6fc to
c85819a
Compare
- Parse and collect version and download_url for conan package - Override the assembly to enhance the package data from conanfile.py Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
keshav-space
force-pushed
the
2388-support-conan
branch
from
c248517 to
f60b309
Compare
There was a problem hiding this comment.
@keshav-space Thanks++
Looking great already, I had some questions and comments for you to consider, see below.
| ) | ||
|
|
||
| @classmethod | ||
| def assemble( |
There was a problem hiding this comment.
Usually we have the assemble function under a base class and then inherit that in all other datafile handlers if these manifests can exist on their own and also together, to cover all the cases, would that also benifit us here?
There was a problem hiding this comment.
conanfile.py can exist on its own, but conandata.yml should not exist in isolation. We need the custom assembly only in the case of conandata.yml
There was a problem hiding this comment.
Which brings to light the limits of a single-file-at-a-time approach. Should we start looking outside of the current file? ScanCode is not design for this at all though for now.
There was a problem hiding this comment.
In case of conan, we need to process 2 files to obtain the package data. However, if we encounter a scenario where we have more than 2 files that need to be processed to obtain package data, processing multiple files at once would be helpful. Otherwise, the assembly will become a bit complex.
tests/packagedcode/data/conan/recipes/boost/manifest/conanfile.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Tasks
Run tests locally to check for errors.