Added new copyright test cases #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek <abhishek.pandey.3237@gmail.com>
Signed-off-by: abhishak3 <abhishek.pandey.3237@gmail.com>
pombredanne
reviewed
Mar 22, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thank you ++
This is looking great. Still need to review each results in details though.
pombredanne
requested changes
Apr 19, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! See some minor changes to mark some tests as failing for now.
See https://github.com/nexB/scancode-toolkit/blob/ebb55c341bc6ba644d2be0e531ffbfc2948bca47/tests/cluecode/data/generated/copyright_30.txt.yml#L9 for an example.
Nouns NNs and Prper nouns NNPs should be limited in length. For now these texts are expected to fail until we add a limit, say of 50 characters. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
approved these changes
Apr 20, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM. Thanks! metrging now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2299
Added some new copyright test cases.