Evaluate live setup.py with a new --insecure option #62 #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TG1999
force-pushed
the
insecure-option
branch
from
d147fea to
058727d
Compare
pombredanne
changed the title
pombredanne
requested changes
Aug 31, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks... See some feedback FYI.
TG1999
force-pushed
the
insecure-option
branch
from
4281d75 to
fdb0470
Compare
Reference: #62 Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
* Imports requirements.py from cookiecutter-invenio-module. Co-authored-by: Jiri Kuncar <jiri.kuncar@cern.ch> Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
* Migrates from argparse to click. * Add support for specifying path to setup.py and requirements file. Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
* Changes `invenio-software.org` to `inveniosoftware.org` to use the same dashless canonical ID everywhere (GitHub, Twitter, Web). Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
* FIX Fixes problem when the setup.py command plays with `__file__` to read, exec, or whatever. Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
* FIX Fixes problem when the setup.py command try to import the package its about to install in order to get the information like the version. E.g. Django does that. Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
* FIX Makes `--extras` option accepting comma separated values as described in help. (closes #14) Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
* FIX Sphinx 1.5+ drops support for Python 2.6 and 3.3. * NEW Adds Python 3.6 support. Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
* FIX Accepts non-`-e` packages from devel file. Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
* Adds support for markers Signed-off-by: Krzysztof Nowak <k.nowak@cern.ch>
- Add configuration for yapf auto-formatting. (closes #19) Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
* Fixes issue with conditions on extra_require not being taken into account. Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
* Fixes issue with upper version requirements being stripped from the output. Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
* Fixes fatal error if setup is called under 'if __name__ == "__main__":'
Closes #35 Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
* Includes the minimum version additionally to the X.* specifier.
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch> Co-authored-by: Christian Clauss <cclauss@me.com>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
- fix pydocstyle and pycodestyle issues - adapt tests to new dependencies closes #52
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
insecure-option
branch
from
fdb0470 to
37375d2
Compare
remove unused code Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
reviewed
Sep 20, 2022
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
approved these changes
Sep 27, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! See a few nitpickings for your consideration and then go ahead, merge and release
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #62
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com