Support comments in netrc file #107 #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
requested changes
Feb 10, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks... see some comments to consider
Member
|
Also, I wonder if we really need tinynetrc and cannot instead directly use the netrc standard library module? |
Contributor
Author
Makes sense trying the standard netrc module |
TG1999
force-pushed
the
ignore_comments_from_netrc
branch
from
4f5c636 to
9f265fb
Compare
pombredanne
approved these changes
Feb 16, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM! you just need to remove the dep on tinynetrc
TG1999
force-pushed
the
ignore_comments_from_netrc
branch
from
9b9013a to
8c84cb9
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
ignore_comments_from_netrc
branch
from
8c84cb9 to
9bdb540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #107
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com