Skip to content

Conversation

@vreuter
Copy link

@vreuter vreuter commented Mar 14, 2023

Close #16

Hit the issue described in #16 and went with the suggestion posted there, just opting for import of the library and the qualified name at the call site, to match what looks like the import standard for this project (or at least for the relevant file).

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++
Do you think you could add a small test to ensure we will not regress?

@vreuter
Copy link
Author

vreuter commented Mar 14, 2023

Thank you ++ Do you think you could add a small test to ensure we will not regress?

Yeah absolutely, can you advise on where best to place it? I looked around the tests/ and it looks like there are a couple candidates, happy to go with whatever project creators / maintainers prefer @pombredanne

Do you understand why the CI fails? From quick glance I couldn't tell what's prompting the errors on this first commit, compared with the latest commit on main

@Akasurde
Copy link

Akasurde commented Sep 8, 2023

Any updates?

@jkowalleck
Copy link

is superseded by #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequirementsFile.from_string() results in NameError: name 'Path' is not defined

4 participants