-
-
Notifications
You must be signed in to change notification settings - Fork 19
Remove vendored out dependencies from pip #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was copied from pip version 20.1.1. Only vcs module and its dependencies were left. Some files from utils module had some unrelated functionality removed to support this cleanup. All MYPY checks were removed as they were unused. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
While all pip's code should've been submitted with license and copyright info, this commit resolves the issue for code mentioned in the commit msg title. Authors were gathered in following way: From pip: https://github.com/pypa/pip.git checked out on: 20.1.1 tag (commit: 8356bc5161e0a9b3054f0e04e12d18feae4c2b46) from repository root, following command was run to get all authors of vcs package: $ git shortlog -s -- src/pip/_internal/vcs/ Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
While all pip's code should've been submitted with license and copyright info, this commit resolves the issue for code mentioned in the commit msg title. Authors were gathered in following way: From pip: https://github.com/pypa/pip.git checked out on: 20.1.1 tag (commit: 8356bc5161e0a9b3054f0e04e12d18feae4c2b46) from repository root, following command was run to get all authors of vcs package: $ for f in src/pip/_internal/utils/*; do echo $f; git shortlog -s -- $f; done Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
While all pip's code should've been submitted with license and copyright info, this commit resolves the issue for code mentioned in the commit msg title. Authors were gathered in following way: From pip: https://github.com/pypa/pip.git checked out on: 20.1.1 tag (commit: 8356bc5161e0a9b3054f0e04e12d18feae4c2b46) from repository root, following command was run to get all authors of vcs package: $ git shortlog -s -- src/pip/_internal/exceptions.py Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
This is to follow scancode-toolkit and other tools in supported versions. Also due to lack of some functionality in older py versions then 3.6.* Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
This is the first step to dropping Python2 support. Some checks for fragments were removed as they are supported in python3.6+. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
This is a step towards dropping Python2 support. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
A step towards removing py2 support. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
This is a step towards dropping Python2 support. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
No six dependencies are left in the code. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
Until logging from pip.vcs is cleaned-up and adjusted for fetchcode, previous is used with colorama disabled. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
It wasn't used in fetchcode anyway thus decorator was also removed. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
vendored one was used for py2 support. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
This is to remove all vendored code that is hard to update. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
All vendored dependencies were removed. Signed-off-by: Alexander Mazuruk <a.mazuruk@samsung.com>
will resubmit with updated pip |
pombredanne
pushed a commit
that referenced
this pull request
May 10, 2022
Do not use Python 3.6 on Windows 2022 jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also support for py2 has been removed.
depends on (in order) #57, #58