Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable optional installation #128

Merged
merged 4 commits into from
Oct 13, 2018
Merged

Enable optional installation #128

merged 4 commits into from
Oct 13, 2018

Conversation

sebix
Copy link
Contributor

@sebix sebix commented Mar 4, 2018

Adds a setup.py and MANIFEST which allows the installation of the program.

codingo
codingo approved these changes Mar 27, 2018
View reviewed changes
Copy link

@codingo codingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled into a local VM (Kali, without sublist3r) and works as expected. Target languages appear ok.

@nwalsh1995
Copy link
Contributor

I don't think hooking into the main function is a good idea as you will miss all of the command line helpers. Refactor the parts under if __name__ == "__main__" to a function and then call that function to retain functionality.

@sebix
Copy link
Contributor Author

sebix commented Apr 12, 2018

Thanks for the pointer @nwalsh1995 Pushed a fix

@aboul3la aboul3la merged commit a9ccc8f into aboul3la:master Oct 13, 2018
@aboul3la
Copy link
Owner

Thanks a lot @sebix for your PR and apologies for this very late response.

I approved your PR and it's merged now to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingo codingo codingo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebix @nwalsh1995 @aboul3la @codingo