Skip to content

Commit

Permalink
Enable CONF_STATION_UPDATES by default on AEMET (home-assistant#111214)
Browse files Browse the repository at this point in the history
* aemet: set CONF_STATION_UPDATES default to True

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

* tests: aemet: check CONF_STATION_UPDATES default form value

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

* Revert "tests: aemet: check CONF_STATION_UPDATES default form value"

This reverts commit f0f95da.

* tests: aemet: parametriz test_form_options

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

---------

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
  • Loading branch information
Noltari authored Feb 25, 2024
1 parent 8c50e24 commit b3e1019
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 21 deletions.
2 changes: 1 addition & 1 deletion homeassistant/components/aemet/config_flow.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

OPTIONS_SCHEMA = vol.Schema(
{
vol.Required(CONF_STATION_UPDATES): bool,
vol.Required(CONF_STATION_UPDATES, default=True): bool,
}
)
OPTIONS_FLOW = {
Expand Down
27 changes: 7 additions & 20 deletions tests/components/aemet/test_config_flow.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,14 @@ async def test_form(hass: HomeAssistant, mock_setup_entry: AsyncMock) -> None:
assert len(mock_setup_entry.mock_calls) == 1


@pytest.mark.parametrize(
("user_input", "expected"), [({}, True), ({CONF_STATION_UPDATES: False}, False)]
)
async def test_form_options(
hass: HomeAssistant,
freezer: FrozenDateTimeFactory,
user_input: dict[str, bool],
expected: bool,
) -> None:
"""Test the form options."""

Expand All @@ -87,30 +92,12 @@ async def test_form_options(
assert result["step_id"] == "init"

result = await hass.config_entries.options.async_configure(
result["flow_id"], user_input={CONF_STATION_UPDATES: False}
result["flow_id"], user_input=user_input
)

assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY
assert entry.options == {
CONF_STATION_UPDATES: False,
}

await hass.async_block_till_done()

assert entry.state is ConfigEntryState.LOADED

result = await hass.config_entries.options.async_init(entry.entry_id)

assert result["type"] == data_entry_flow.FlowResultType.FORM
assert result["step_id"] == "init"

result = await hass.config_entries.options.async_configure(
result["flow_id"], user_input={CONF_STATION_UPDATES: True}
)

assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY
assert entry.options == {
CONF_STATION_UPDATES: True,
CONF_STATION_UPDATES: expected,
}

await hass.async_block_till_done()
Expand Down

0 comments on commit b3e1019

Please sign in to comment.