[MMB-200] Implement cursor offsets rather than intervals#105
Merged
Conversation
surminus
force-pushed
the
laura-positional-batching
branch
from
93b71a0 to
abf8599
Compare
dpiatek
reviewed
Aug 9, 2023
dpiatek
reviewed
Aug 9, 2023
surminus
force-pushed
the
laura-positional-batching
branch
5 times, most recently
from
3a67f27 to
0f71ac9
Compare
surminus
changed the title
dpiatek
approved these changes
Aug 11, 2023
Instead of calculating an even interval based upon the length of the buffer and the batchtime, instead pass along movement offsets as part of the message, and replay these offsets as part of the dispensing. This ensures you get a more accurate representation of cursor movements. The first offset is also 0, which removes the slight delay that was present in the original implementation, since the calculated interval was always the same. Since we are immediately invoking the all the data in the buffer to create the timeouts, we can simplify the code to always just use whatever data is present in the buffer as the gate to whether we should call `emitFromBatch()`. This means we can remove the logic related to `handlerRunning`. Due to the way we are immediately processing the buffer, it means we cannot test in the same way we did previously, so tests have been amended to accomodate this.
surminus
force-pushed
the
laura-positional-batching
branch
from
0f71ac9 to
1a06c7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of calculating an even interval based upon the length of the buffer and the batchtime, instead pass along movement offsets as part of the message, and replay these offsets as part of the dispensing.
This ensures you get a more accurate representation of cursor movements.
The first offset is also 0, which removes the slight delay that was present in the original implementation, since the calculated interval was always the same.
Since we are immediately invoking the all the data in the buffer to create the timeouts, we can simplify the code to always just use
whatever data is present in the buffer as the gate to whether we should call
emitFromBatch(). This means we can remove the logic related tohandlerRunning.Due to the way we are immediately processing the buffer, it means we cannot test in the same way we did previously, so tests have been amended to accommodate this.
Testing
Before
5
15
25
After
5
15
25