Release/2.0.13 #615
Release/2.0.13 #615
Conversation
WalkthroughVersion bumped from 2.0.12 to 2.0.13 and changelog updated. No code or API changes beyond updating the version constant and package metadata. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CHANGELOG.md (1)
3-10: Changelog entry reads well; minor nit — avoid bare URLs for PR linksConform to prior entries and silence markdownlint MD034 by linking PR numbers explicitly.
Apply this diff:
-## What's Changed -* Removed await from sync `connect()` function call by @kavindail in https://github.com/ably/ably-python/pull/605 -* Upgraded websockets dependency to support 15+ by @ttypic in https://github.com/ably/ably-python/pull/612 +## What's Changed +* Removed await from sync `connect()` function call by @kavindail in [#605](https://github.com/ably/ably-python/pull/605) +* Upgraded websockets dependency to support 15+ by @ttypic in [#612](https://github.com/ably/ably-python/pull/612)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)ably/__init__.py(1 hunks)pyproject.toml(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[grammar] ~7-~7: There might be a mistake here.
Context: ...re/v2.0.12...v2.0.13) ## What's Changed * Removed await from sync connect() func...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
8-8: Bare URL used
(MD034, no-bare-urls)
9-9: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: check (3.13)
- GitHub Check: check (3.9)
- GitHub Check: check (3.10)
- GitHub Check: check (3.12)
- GitHub Check: check (3.11)
- GitHub Check: check (3.7)
- GitHub Check: check (3.8)
🔇 Additional comments (1)
ably/__init__.py (1)
18-18: Approve lib_version bump to 2.0.13 — all versions are in syncThe numeric version in
ably/__init__.pyandpyproject.tomlboth resolve to2.0.13, and there are no lingering references to2.0.12.• ably/init.py – lib_version = 2.0.13
• pyproject.toml – version = 2.0.13To avoid matching file:line prefixes in future checks, you can use a more precise ripgrep invocation:
#!/usr/bin/env bash set -euo pipefail # Extract just the version number (no line/file prefixes) v_init=$(rg -Po "lib_version\\s*=\\s*'\\K[^']+" ably/__init__.py | head -n1) v_poetry=$(rg -Po 'version\\s*=\\s*"\\K[^"]+' pyproject.toml | head -n1) echo "ably/__init__.py lib_version = $v_init" echo "pyproject.toml version = $v_poetry" if [[ "$v_init" != "$v_poetry" ]]; then echo "ERROR: version mismatch" exit 1 fi echo "No stale references to 2.0.12 found."No API touchpoints here; safe change.
| [tool.poetry] | ||
| name = "ably" | ||
| version = "2.0.12" | ||
| version = "2.0.13" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Poetry version set to 2.0.13 — LGTM
Straightforward metadata bump; aligns with ably/init.py.
If your release process expects a Git tag to back the CHANGELOG compare link, ensure a tag "v2.0.13" is pushed after merge:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Intended tag: v$(rg -nUP '^[[:space:]]*version[[:space:]]*=[[:space:]]*"([^"]+)"' -or '$1' pyproject.toml | head -n1)"
# Example tagging (uncomment when ready):
# git tag -s "v$(rg -nUP '^[[:space:]]*version[[:space:]]*=[[:space:]]*"([^"]+)"' -or '$1' pyproject.toml | head -n1)" -m "Release $(date -I)"
# git push origin --tagsLength of output: 180
🏁 Script executed:
#!/bin/bash
set -euo pipefail
grep -n "__version__" ably/__init__.pyLength of output: 58
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Searching for version assignments in ably package"
rg -nP '(__version__|version)\s*=' --glob 'ably/**/*.py' || trueLength of output: 1883
Update release tagging snippet to correctly extract version
The existing example uses rg -nUP … -or '$1', which outputs 3:2.0.13 (including the line number) instead of the intended 2.0.13. Please update the snippet in the review comment as follows:
• pyproject.toml tagging example
- Before:
echo "Intended tag: v$(rg -nUP '^[[:space:]]*version\s*=\s*"([^"]+)"' -or '$1' pyproject.toml | head -n1)"
- After:
# Extracts just the version string (e.g. "2.0.13") TAG=v$(rg -Po '(?<=version\s*=\s*")[^"]+' pyproject.toml | head -n1) echo "Intended tag: $TAG" # Tag and push git tag -s "$TAG" -m "Release $TAG" git push origin "$TAG"
Version metadata in pyproject.toml now aligns with ably/__init__.py’s lib_version = '2.0.13'. Once merged, ensure the annotated tag v2.0.13 is created and pushed so that your CHANGELOG links resolve correctly.
🤖 Prompt for AI Agents
pyproject.toml lines 3-3: the release-tagging example in the review comment
needs to be replaced so it extracts only the version string (no line numbers)
and then creates/pushes an annotated tag; update the snippet to use ripgrep with
a Perl regex lookbehind to capture the value inside the version quotes, pipe to
head -n1, prefix with "v" into a TAG variable, echo the intended tag, create a
signed annotated tag with that TAG and message "Release $TAG", and push the tag
to origin.
What's Changed
connect()function call by @kavindail in Remove await from sync connect() function call #605Summary by CodeRabbit