Support PHP 8, drop versions below 7.2 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavid
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
The PR subject says it drops support below 7.4, but the composer file says it works with PHP 7.2 and 7.3, though it's only tested against 7.4 (and 8.0). Also there's nothing in the README file saying what versions of PHP are supported, should it? Otherwise it looks Good.
owenpearson
force-pushed
the
feature/php-8
branch
from
4812f18 to
8281a86
Compare
|
@jdavid Thanks, I've addressed both these issues now 👍 |
owenpearson
changed the title
|
@owenpearson LGTM |
QuintinWillison
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.