Skip to content

Php-Laravel Ably Agent Header #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 5, 2022
Merged

Php-Laravel Ably Agent Header #17

merged 15 commits into from
Apr 5, 2022

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 30, 2022 •
edited
Loading

@sacOO7 sacOO7 changed the title Laravel agent header Php-Laravel Ably Agent Header Mar 30, 2022
@sacOO7 sacOO7 marked this pull request as draft March 30, 2022 09:40
lmars
lmars reviewed Mar 30, 2022
View reviewed changes
@sacOO7 sacOO7 marked this pull request as ready for review March 30, 2022 19:24
@sacOO7 sacOO7 requested a review from owenpearson March 30, 2022 19:26
@sacOO7 sacOO7 requested review from ikbalkaya March 30, 2022 19:38
ikbalkaya
ikbalkaya approved these changes Mar 31, 2022
View reviewed changes
Copy link

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about PHP but this looks good to me

owenpearson
owenpearson approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@owenpearson owenpearson merged commit 04aaa2c into main Apr 5, 2022
@owenpearson owenpearson deleted the feature/laravel-agent-header branch April 5, 2022 11:49
@sacOO7 sacOO7 mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmars lmars lmars approved these changes

@owenpearson owenpearson owenpearson approved these changes

@ikbalkaya ikbalkaya Awaiting requested review from ikbalkaya

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RSC7d (Ably-Agent header)
4 participants
@sacOO7 @ikbalkaya @lmars @owenpearson