Switch from git protocol to https for msgpack dependency - #515
Merged
Conversation
Apparently some environments block the git protocol port
paddybyers
reviewed
Jun 14, 2018
paddybyers
left a comment
paddybyers
left a comment
Member
There was a problem hiding this comment.
Is it our plan to make this change generally?
Member
Author
in ably-js, msgpack-js is the only production dependency that's fetched from github. No idea about any other client libs |
Member
Right, that was my question, but we don't have other public repos that use npm so I guess it's moot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently some environments block the git protocol port, see https://app.intercom.io/a/apps/ua39m1ld/inbox/inbox/conversation/16992208828