[DTP-960, DTP-961] Add Live Objects access API#1883
[DTP-960, DTP-961] Add Live Objects access API#1883VeskeR merged 2 commits intointegration/liveobjectsfrom
Conversation
|
Warning Rate limit exceeded@VeskeR has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 47 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fe80195 to
3e95eb1
Compare
394b3b6 to
22f80e3
Compare
mschristensen
left a comment
There was a problem hiding this comment.
Could we add tests for the access API relying on the existing initialValue support to initialise the object data in tests?
| // These are the files that are allowed to contribute >= `threshold` bytes to the LiveObjects bundle. | ||
| const allowedFiles = new Set([ | ||
| 'src/plugins/liveobjects/index.ts', | ||
| 'src/plugins/liveobjects/livemap.ts', |
There was a problem hiding this comment.
need only (and only) to add files that exceed threshold value (100 bytes currently).
it's intended this way to get notified of new files exceeding this threshold (thus potentially bloating the size of the module).
so livecounter can be added once it has a bit more code (pretty soon honestly)
We don't expose live object classes as part of the public API based on our design, so there is no way to test this using only the public API we have now. We will be able to create new objects using |
Resolves DTP-960
Resolves DTP-961
3e95eb1 to
d7211a4
Compare
22f80e3 to
e5f0d8f
Compare
This PR is based on #1882, please review it first.
Resolves DTP-960, DTP-961