fix: use appropriate error code for channel attachment timeout#961
Merged
fix: use appropriate error code for channel attachment timeout#961
Conversation
Previously, for channel attachment timeouts we were using error code 91200 which is not documented for users and was removed from the specification somewhere around version 0.9. It looks like it was removed almost immediately after it was implemented in ably-java. This change fixes this by changing the code to 90007 which is used elsewhere and more appropriate for this use-case (used in detach in ably-java, and in ably-js). Fixes #959
owenpearson
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, for channel attachment timeouts we were using error code 91200 which is not documented for users and was removed from the specification somewhere around version 0.9. It looks like it was removed almost immediately after it was implemented in ably-java.
This change fixes this by changing the code to 90007 which is used elsewhere and more appropriate for this use-case (used in detach in ably-java, and in ably-js).
Fixes #959