Merged
Conversation
sacOO7
changed the title
sacOO7
force-pushed
the
refactor/incremental-backoff-jitter
branch
from
1052e13 to
5476b35
Compare
Collaborator
Author
|
Flaky integration tests are being fixed with #949 |
sacOO7
force-pushed
the
refactor/incremental-backoff-jitter
branch
from
4033cfc to
8a26519
Compare
AndyTWF
reviewed
Jul 3, 2023
AndyTWF
reviewed
Jul 4, 2023
AndyTWF
approved these changes
Jul 5, 2023
owenpearson
requested changes
Jul 5, 2023
Member
owenpearson
left a comment
owenpearson
left a comment
There was a problem hiding this comment.
tests look fine to me, i'm not sure about the disconnect retry implementation though:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.