Fix equals() on token details

[ikbalkaya]

Fixes #926

[AndyTWF]

The cast on line 363 would throw a ClassCastException if you tried to compare anything other than a TokenDetails or subclass to a TokenDetails. Is it better to leave this behaviour in place, as it very quickly shows to anyone working on the library that they're trying to make an illogical comparison?

[ikbalkaya]

The cast on line 363 would throw a ClassCastException if you tried to compare anything other than a TokenDetails or subclass to a TokenDetails. Is it better to leave this behaviour in place, as it very quickly shows to anyone working on the library that they're trying to make an illogical comparison?

The conventional contract in for equals in Java is to check type and return false if type isn't what is expected by the object itself. I do not think raising an exception on equals would be appropriate. In the meantime, I realized that hashcode also wasn't implemented for this which I added here 565aed9

[AndyTWF]

The cast on line 363 would throw a ClassCastException if you tried to compare anything other than a TokenDetails or subclass to a TokenDetails. Is it better to leave this behaviour in place, as it very quickly shows to anyone working on the library that they're trying to make an illogical comparison?

The conventional contract in for equals in Java is to check type and return false if type isn't what is expected by the object itself. I do not think raising an exception on equals would be appropriate. In the meantime, I realized that hashcode also wasn't implemented for this which I added here 565aed9

Fair play - I wasn't able to find anything too authoritative on conventions when I looked, but happy to go with convention :)