Add reason to pending message instead of creating an ErrorInfo#922
Merged
Add reason to pending message instead of creating an ErrorInfo#922
Conversation
github-actions
bot
temporarily deployed
to
staging/pull/922/javadoc
AndyTWF
reviewed
Feb 24, 2023
github-actions
bot
temporarily deployed
to
staging/pull/922/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/922/javadoc
This will assert that any error that arrived for completion waiters must also contain message
ikbalkaya
force-pushed
the
error_message_to_pending_message_queue_failure
branch
from
194ff9b to
acae478
Compare
AndyTWF
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes
reasontofail()fromfailQueuedMessagesinstead of creating an emptyErrorInfo.Fixes #920