Drop messages where channel does not exist#914
Merged
Conversation
At the moment, if a message is received and a channel does not exist the channel is created (via channels.get) to process the message. This can lead to issues with channels.release, which also detaches the channel after removing it from the channel map. If the timing is unfortunate, then the DETACH message will come back and re-create the channel, meaning it cannot be recreated afresh later. This change fixes the issues by dropping any messages that are received for a non existent channel and logs the fact that this has happened. Fixes #913
AndyTWF
requested review from
QuintinWillison,
ikbalkaya and
paddybyers
and removed request for
QuintinWillison
ikbalkaya
suggested changes
Feb 6, 2023
Contributor
ikbalkaya
left a comment
ikbalkaya
left a comment
There was a problem hiding this comment.
Code looks good overall. I have made some requests that will hopefully improve the code.
lib/src/test/java/io/ably/lib/test/realtime/RealtimeChannelTest.java
Outdated
Show resolved
Hide resolved
ikbalkaya
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, if a message is received and a channel does not exist the channel is created (via channels.get) to process the message.
This can lead to issues with channels.release, which also detaches the channel after removing it from the channel map. If the timing is unfortunate, then the DETACH message will come back and re-create the channel, meaning it cannot be recreated afresh later.
This change fixes the issues by dropping any messages that are received for a non existent channel and logs the fact that this has happened.
Fixes #913