Merged
Conversation
I was tempted to make ABLY_VERSION_NUMBER private, as it's not used anywhere outside of this class within this SDK, however there's an outside chance downstream users of the SDK might be using it for some reason.
This is because we need this SDK to take advantage of service-side support for automatic presence re-entry, because RTP17c (client-led automatic re-entry) is yet to be implemented in this SDK. This is a temporary patch until we fix this properly under #859
QuintinWillison
requested review from
KacperKluka,
SimonWoolf,
davyskiba,
ikbalkaya and
paddybyers
SimonWoolf
approved these changes
Nov 24, 2022
davyskiba
approved these changes
Nov 24, 2022
ikbalkaya
approved these changes
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is our second attempt to quick-fix an urgent issue relating to presence re-entry.
The first attempt was in #858.
Closes #857.