Minimum API Level supported for Android is 19 (KitKat, v.4.4)#804
Merged
QuintinWillison merged 2 commits intomainfrom Jun 21, 2022
Merged
Minimum API Level supported for Android is 19 (KitKat, v.4.4)#804QuintinWillison merged 2 commits intomainfrom
QuintinWillison merged 2 commits intomainfrom
Conversation
For example, AutoCloseable. Also, our targetSdkVersion did not match our compileSdkVersion.
QuintinWillison
added
the
bug
QuintinWillison
requested review from
AndyNicks,
KacperKluka,
ikbalkaya and
qsdigor
This was referenced Jun 20, 2022
AndyNicks
approved these changes
Jun 20, 2022
KacperKluka
approved these changes
Jun 21, 2022
ikbalkaya
approved these changes
Jun 21, 2022
Contributor
ikbalkaya
left a comment
ikbalkaya
left a comment
There was a problem hiding this comment.
Apart from the possibility of some of (if there are any) of our users missing new SDK versions, looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were declaring incorrectly.
I propose releasing this with our next version
1.2patch and, as such, am treating this change as foundational to my fix for #801.