TransportParams support in ClientOptions #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikurek
requested review from
QuintinWillison,
lukasz-szyszkowski and
KacperKluka
KacperKluka
suggested changes
Apr 7, 2022
android/src/main/java/io/ably/flutter/plugin/AblyMessageCodec.java
Outdated
Show resolved
Hide resolved
lukasz-szyszkowski
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #108. I've found out that this feature was implemented on Dart side, but it wasn't implemented in iOS and Android bridges, probably because of differences in implementation of these methods for each platform (iOS requires
NSDictionaryand Android requiresParam[]array). I've implemented bridges on each platform and now it seems to work fine 🙂