Skip to content

[AIT-287] Pass the RESUMED flag to LiveObjects onChannelAttached #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lawrence-forooghian wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[AIT-287] Pass the RESUMED flag to LiveObjects onChannelAttached #2185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ let package = Package(
.package(name: "msgpack", url: "https://github.com/rvi/msgpack-objective-C", from: "0.4.0"),
.package(name: "AblyDeltaCodec", url: "https://github.com/ably/delta-codec-cocoa", from: "1.3.5"),
.package(name: "Nimble", url: "https://github.com/quick/nimble", from: "11.2.2"),
.package(name: "ably-cocoa-plugin-support", url: "https://github.com/ably/ably-cocoa-plugin-support", from: "1.0.0")
// TODO: Unpin before release
.package(name: "ably-cocoa-plugin-support", url: "https://github.com/ably/ably-cocoa-plugin-support", .revision("2e640ce2ef422cd5ef693a9e1111400e9985e088"))
],
targets: [
.target(
Expand Down
10 changes: 8 additions & 2 deletions Source/ARTRealtimeChannel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,8 +810,14 @@ - (void)setAttached:(ARTProtocolMessage *)message {
self.modes = message.channelModes;

#ifdef ABLY_SUPPORTS_PLUGINS
[self.realtime.options.liveObjectsPlugin nosync_onChannelAttached:self
hasObjects:message.hasObjects];
if ([self.realtime.options.liveObjectsPlugin respondsToSelector:@selector(nosync_onChannelAttached:hasObjects:resumed:)]) {
[self.realtime.options.liveObjectsPlugin nosync_onChannelAttached:self
hasObjects:message.hasObjects
resumed:message.resumed];
} else {
[self.realtime.options.liveObjectsPlugin nosync_onChannelAttached:self
hasObjects:message.hasObjects];
}
#endif

if (state == ARTRealtimeChannelAttached) {
Expand Down
Loading