Skip to content

[AIT-287] Add the RESUMED flag to onChannelAttached #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lawrence-forooghian wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[AIT-287] Add the RESUMED flag to onChannelAttached #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7388cf
Remove outdated comment
lawrence-forooghian Jan 21, 2026
2e640ce
Add the RESUMED flag to onChannelAttached
lawrence-forooghian Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion Sources/_AblyPluginSupportPrivate/include/APLiveObjectsPlugin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ NS_SWIFT_SENDABLE
- (NSDictionary<NSString *, id> *)encodeObjectMessage:(id<APObjectMessageProtocol>)objectMessage
format:(APEncodingFormat)format;

/// Called when a channel received an `ATTACHED` `ProtocolMessage`. (This is copied from ably-js, will document this method properly once exact meaning decided.)
/// Called when a channel received an `ATTACHED` `ProtocolMessage`.
///
/// Superseded by the optional `nosync_onChannelAttached:hasObjects:resumed:` method,
/// which includes the `RESUMED` flag. If ably-cocoa detects that the plugin implements the
/// newer method, it will call that instead of this one.
///
/// Parameters:
/// - channel: The channel that received the `ProtocolMessage`.
Expand Down Expand Up @@ -91,6 +95,22 @@ NS_SWIFT_SENDABLE
- (void)nosync_onConnectedWithConnectionDetails:(nullable id<APConnectionDetailsProtocol>)connectionDetails
channel:(id<APRealtimeChannel>)channel;

@optional

/// Called when a channel received an `ATTACHED` `ProtocolMessage`.
///
/// This method supersedes `nosync_onChannelAttached:hasObjects:` by including the `RESUMED` flag.
/// If this method is implemented, ably-cocoa will call it instead of `nosync_onChannelAttached:hasObjects:`.
///
/// Parameters:
/// - channel: The channel that received the `ProtocolMessage`.
/// - hasObjects: Whether the `ProtocolMessage` has the `HAS_OBJECTS` flag set.
/// - resumed: Whether the `ProtocolMessage` has the `RESUMED` flag set.
- (void)nosync_onChannelAttached:(id<APRealtimeChannel>)channel
hasObjects:(BOOL)hasObjects
resumed:(BOOL)resumed
NS_SWIFT_NAME(nosync_onChannelAttached(_:hasObjects:resumed:));

@end

/// An `ObjectMessage`, as found in the `state` property of an `OBJECT` or `OBJECT_SYNC` `ProtocolMessage`.
Expand Down