[AIT-322] Support protocol version bump to v6#10
[AIT-322] Support protocol version bump to v6#10lawrence-forooghian wants to merge 1 commit intointegration/protocol-v6from
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughThis PR introduces protocol version compatibility flags to the plugin API and establishes comprehensive documentation for managing Realtime protocol versions, including dependency relationships, breaking change procedures, and coordinated release workflows. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lawrence-forooghian
changed the base branch from
main
to
integration/protocol-v6
lawrence-forooghian
force-pushed
the
AIT-322-v6-ProtocolMessage
branch
2 times, most recently
from
ecbf903 to
c20f969
Compare
lawrence-forooghian
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 54-66: The fenced code blocks containing Objective-C declarations
(the blocks showing the usesLiveObjectsProtocolV6 and compatibleWithProtocolV6
`@property` docs) are missing language identifiers and trigger markdownlint MD040;
update each triple-backtick fence to include the objc language tag (e.g.,
```objc) for the blocks that contain the usesLiveObjectsProtocolV6 and
compatibleWithProtocolV6 snippets so the README code blocks are properly
labeled.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
README.mdSources/_AblyPluginSupportPrivate/include/APLiveObjectsPlugin.hSources/_AblyPluginSupportPrivate/include/APPluginAPI.h
We need to start using protocol version 6 as it introduces new LiveObjects functionality. The main problem to solve is: how do we make sure that ably-cocoa doesn't force a protocol version on a plugin that can't handle that version? Here we propose a simple solution. It's a bit clunky, but to be honest our whole plugin mechanism is a bit clunky so I think we can live with this additional clunkiness. One other problem of the solution given here — that is, doing major plugin-api releases — is that if, in the future, we have further plugins, then we'll have to do new releases of _all_ the plugins just because we needed to bump plugin-support for one of them. I hope that by the time we need to do further plugins we'll have moved to ably-swift (with plugins in-repo) and we won't have to worry about this! Resolves ably/ably-liveobjects-swift-plugin#107. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lawrence-forooghian
force-pushed
the
AIT-322-v6-ProtocolMessage
branch
from
c20f969 to
e015e70
Compare
1 participant
Note: This targets the
integration/protocol-v6branch.Summary
We need to start using protocol version 6 as it introduces new LiveObjects functionality.
The main problem to solve is: how do we make sure that ably-cocoa doesn't force a protocol version on a plugin that can't handle that version?
Here we propose a simple solution. It's a bit clunky, but to be honest our whole plugin mechanism is a bit clunky so I think we can live with this additional clunkiness.
One other problem of the solution given here — that is, doing major plugin-api releases — is that if, in the future, we have further plugins, then we'll have to do new releases of all the plugins just because we needed to bump plugin-support for one of them. I hope that by the time we need to do further plugins we'll have moved to ably-swift (with plugins in-repo) and we won't have to worry about this!
Resolves ably/ably-liveobjects-swift-plugin#107.
Related PRs
ObjectMessagestructure ably-liveobjects-swift-plugin#114Summary by CodeRabbit
Documentation
New Features